Bugfix: Flaky test in IonValueDeserializerTest#620
Merged
cowtowncoder merged 1 commit intoFasterXML:3.xfrom Oct 22, 2025
Merged
Conversation
cowtowncoder
approved these changes
Oct 22, 2025
cowtowncoder
added a commit
that referenced
this pull request
Oct 22, 2025
Member
|
Thank you @cperkkk ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
This pull request addresses 1 flaky test, in the
jackson-dataformats-binaryproject. The test was failing intermittently due to assumptions about the ordering of fields returned by the code under test.Test Affected
IonValueDeserializerTest#shouldBeAbleToSerializeAndDeserializeIonValueDataWithIncludeNonNullWhy the test fails
The test compares the exact string representation which can be returned in any order (when using
HashMapin the underlying implementation). I switched the test to useLinkedHashMapinstead to guarantee ordering.How to reproduce the test failure
Use the TestingResearchIllinois's NonDex tool and run:
Before the fix, the test failed intermittently with errors similar to:
Expected results
The test should pass consistently, regardless of the order of fields in the returned response.
Actual results
Before the fix, the test failed intermittently due to changes in the order of the returned response.
Validation
Test Results
Additional Notes
Let me know if further improvements or clarifications are needed!